Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36175 ) Change subject: util/lint: Update license header text for SPDX headers. ...................................................................... Patch Set 3: Code-Review+1 (2 comments) https://review.coreboot.org/c/coreboot/+/36175/3/util/lint/lint-000-license-... File util/lint/lint-000-license-headers: https://review.coreboot.org/c/coreboot/+/36175/3/util/lint/lint-000-license-... PS3, Line 76: identifer identifier https://review.coreboot.org/c/coreboot/+/36175/3/util/lint/lint-000-license-... PS3, Line 106: check_for_license 'SPDX-License-Identifier: Apache-2.0' : check_for_license 'SPDX-License-Identifier: BSD-3-Clause' : check_for_license 'SPDX-License-Identifier: GPL-2.0-only' : check_for_license 'SPDX-License-Identifier: GPL-2.0-or-later' : check_for_license 'SPDX-License-Identifier: GPL-3.0-only' : check_for_license 'SPDX-License-Identifier: GPL-3.0-or-later' : check_for_license 'SPDX-License-Identifier: ISC' : check_for_license 'SPDX-License-Identifier: MIT' : check_for_license 'SPDX-License-Identifier: X11'
Probably, however that will require extensive refactoring of this script to look at projects individ […] Also, ISC, MIT and X11 are also permissible in coreboot for imported code (they're GPL-compatible), and libpayload already contains some GPL'd drivers (in principle hidden behind a Kconfig flag, not sure if that's 100% accurate).
So any effort to make license tests per-project is really orthogonal to what this change is doing. -- To view, visit https://review.coreboot.org/c/coreboot/+/36175 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I07a7ca408ac8563e03e189d05ef7729dfb6fc24e Gerrit-Change-Number: 36175 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth@google.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Comment-Date: Fri, 22 Nov 2019 10:53:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Arthur Heymans <arthur@aheymans.xyz> Comment-In-Reply-To: David Hendricks <david.hendricks@gmail.com> Gerrit-MessageType: comment