Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48564 )
Change subject: soc/amd/cezanne: add GPIO definitions ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48564/4/src/soc/amd/cezanne/include... File src/soc/amd/cezanne/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/48564/4/src/soc/amd/cezanne/include... PS4, Line 48:
I see 43-62 in the PPR. […]
oh, those aren't in the IOMUX table and are also missing in picasso. since those don't have an associated IOMUX register, i'm not sure how to handle those properly. it'll probably work if i add #define GPIO_x_IOMUX_GPIOxx 0 for each of those, but i'm not 100% confident about that. so i'd suggest to keep it as it is right now and add those if we need them later on
https://review.coreboot.org/c/coreboot/+/48564/4/src/soc/amd/cezanne/include... PS4, Line 93:
172-183?
same situation as with the ones i commented about above