Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46432 )
Change subject: security/vboot: Make mrc_cache hash functions generic
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46432/1/src/security/vboot/secdata_...
File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/46432/1/src/security/vboot/secdata_...
PS1, Line 420: uint32_t antirollback_read_space_hash(uint32_t index, uint8_t *data, uint32_t size)
BTW there are stub versions of these functions in secdata_mock.c that you need to update as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46432
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c0bb25eafc731ca9c7a95113ab940f55997fc0f
Gerrit-Change-Number: 46432
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 14 Oct 2020 23:08:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment