Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33622 )
Change subject: vendorcode/amd/pi: Integrate Merlin Falcon as a build option ......................................................................
Patch Set 11:
(4 comments)
We're trying something new in gerrit: Before something can be merged now, all remarks have to be marked as resolved.
https://review.coreboot.org/c/coreboot/+/33622/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33622/6//COMMIT_MSG@7 PS6, Line 7: vendorcode/amd/pi: Change Kconfig
It was originally specific, than I had to change it because a lot of what I was doing before changed […]
Done
https://review.coreboot.org/c/coreboot/+/33622/7/src/vendorcode/amd/pi/Kconf... File src/vendorcode/amd/pi/Kconfig:
https://review.coreboot.org/c/coreboot/+/33622/7/src/vendorcode/amd/pi/Kconf... PS7, Line 43: if MERLINFALCON_BINARIES_PRESENT
No need, we already verified that merlinfalcon works well with src/vendorcode/amd/pi/00670F00
Done
https://review.coreboot.org/c/coreboot/+/33622/10/src/vendorcode/amd/pi/Kcon... File src/vendorcode/amd/pi/Kconfig:
https://review.coreboot.org/c/coreboot/+/33622/10/src/vendorcode/amd/pi/Kcon... PS10, Line 48: if SOC_AMD_STONEYRIDGE_FP4 ||
Actually the mistake is worse... it should be […]
Done
https://review.coreboot.org/c/coreboot/+/33622/3/src/vendorcode/amd/pi/Makef... File src/vendorcode/amd/pi/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/33622/3/src/vendorcode/amd/pi/Makef... PS3, Line 32: merlinfalcon
You are correct. Will fix.
Done