Attention is currently required from: V Sowmya, Paul Menzel, Angel Pons, Aamir Bohra.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50993 )
Change subject: Revert "Revert "mb/intel/shadowmountain: Add the ASL code""
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50993/comment/d4e4e58d_ad4361b4
PS2, Line 7: Revert "Revert "mb/intel/shadowmountain: Add the ASL code""
I second that. You might note the out-of-order submission in the commit message.
True, looks "Revert of revert" is kind of bad here, assume someone need to revert again. so like "Revert ..."?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50993
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5aa60730fc9b93fa97b2bafbb8b2714b6b37becc
Gerrit-Change-Number: 50993
Gerrit-PatchSet: 2
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Comment-Date: Mon, 22 Feb 2021 13:34:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment