Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40281 )
Change subject: mb/lenovo/t420s/devicetree.cb: Fix PCIe port definitions ......................................................................
Patch Set 2: Code-Review+2
(4 comments)
Patch Set 2:
Patch Set 1:
Patch Set 1:
It looks like you changed the file permissions. From Jenkins:
File src/mainboard/lenovo/t420s/devicetree.cb has one or more executable bits set in the file permissions.
That usually happens when the coreboot repo is on a filesystem that doesn't support all the permission bits (e. g. Windows machines)
I actually used two Linux boxes, but copied the file over SMB at one stage and didn't notice the change, though I normally check :)
Ah yes, SMB does that 😄
https://review.coreboot.org/c/coreboot/+/40281/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40281/1//COMMIT_MSG@7 PS1, Line 7: src/mainboard/lenovo/t420s/devicetree.cb: Fix PCIe port definitions
Uh, this change doesn't directly enable USB 3.0. It fixes the PCIe root port settings and comments. […]
Done
https://review.coreboot.org/c/coreboot/+/40281/1//COMMIT_MSG@9 PS1, Line 9: The NEC uPD720200A USB 3.0 controller on the T420s is actually connected to
Please wrap lines after 72/75 characters.
Done (fwiw, the limit is 72)
https://review.coreboot.org/c/coreboot/+/40281/1//COMMIT_MSG@10 PS1, Line 10: Enabled RP#5, disabled RP#7 and : updated comments accordingly.
(To make it clear, the suggestion is to use "timeless present" for the changes that the commit does)
Done
https://review.coreboot.org/c/coreboot/+/40281/1//COMMIT_MSG@12 PS1, Line 12:
Test=USB 3.0 controller shows up in lspci.
Done