Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47442 )
Change subject: vc/google/chromeos/sar: Make "SAR not found" log a debug message ......................................................................
Patch Set 3:
(6 comments)
https://review.coreboot.org/c/coreboot/+/47442/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47442/2//COMMIT_MSG@7 PS2, Line 7: chromesos
chromeos
Done
https://review.coreboot.org/c/coreboot/+/47442/2//COMMIT_MSG@7 PS2, Line 7: vendorcode/google/chromesos/sar: Reduce severity of debug message
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/47442/2//COMMIT_MSG@10 PS2, Line 10: debug message
message
Done
https://review.coreboot.org/c/coreboot/+/47442/2//COMMIT_MSG@13 PS2, Line 13: to avoid
avoids
Done
https://review.coreboot.org/c/coreboot/+/47442/2//COMMIT_MSG@13 PS2, Line 13: BIOS_DEBUG
Why not `BIOS_INFO`?
I wanted to keep it debug, in case there is genuine issue of VPD not found.
https://review.coreboot.org/c/coreboot/+/47442/2//COMMIT_MSG@13 PS2, Line 13: Lowering severity to BIOS_DEBUG to avoid this issue
Please add a dot/period at the end.
Done