Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34788 )
Change subject: mb/google/hatch/var/kindred: Config GPIOs and disable eMMC for SSD SKUs
......................................................................
Patch Set 2: Code-Review-1
I don't see the need to introduce yet another way to configure GPIOs. This can all be done from Kindred's override_gpio_table(). If you get the SKU ID inside that function, you can return the table that is appropriate for that SKU.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34788
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d893f0f7339e7b1a1e6b56d1598c0a361c8d604
Gerrit-Change-Number: 34788
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 12 Aug 2019 15:57:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment