Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Angel Pons, Arthur Heymans, Patrick Rudolph, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Nico Huber, Raul Rangel, Marshall Dawson, Arthur Heymans, Patrick Rudolph, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51634
to look at the new patch set (#6).
Change subject: device/azalia_device.c: Unify `wait_for_valid` timeouts ......................................................................
device/azalia_device.c: Unify `wait_for_valid` timeouts
The timeout is never reached when the codec is functioning properly. Using a small timeout value can result in spurious errors with some codecs, e.g. a codec that is slow to respond but operates correctly. When a codec is non-operative, the timeout is only reached once per verb table, thus the impact on booting time is relatively small. So, use a reasonably long enough timeout to cover all possible cases.
Remove the unconditional 25 µs delay and increase the timeout delay. The new value of 1 ms is the maximum of all existing implementations. Currently, the only boards using this code are AMD reference boards: - AMD Bilby - AMD Mandolin - AMD Padmelon
Change-Id: Ia5e4829d404dcecdb9e7a377e896a319cb38531a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/device/azalia_device.c 1 file changed, 11 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/51634/6