[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer/variant/lindar: Disable SA GV for Samsung memory wi...

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51200 )

Change subject: mb/google/volteer/variant/lindar: Disable SA GV for Samsung memory with wrong date code MB
......................................................................

mb/google/volteer/variant/lindar: Disable SA GV for Samsung memory with wrong date code MB

Disable SA GV, because factory used Samsung memory with wrong date code.
So we need to use board version to identify build MB phase to disable SA GV.
Disable SA GV when board version equal one.

BUG=b:179747696
BRANCH=firmware-volteer-13672.B
TEST=Built and booted into OS.

Signed-off-by: Kevin Chang 
Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f
Signed-off-by: Kevin Chang 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51200
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
---
M src/mainboard/google/volteer/romstage.c
M src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h
M src/mainboard/google/volteer/variants/lindar/memory.c
3 files changed, 15 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/romstage.c b/src/mainboard/google/volteer/romstage.c
index f3fb454..8cde5da 100644
--- a/src/mainboard/google/volteer/romstage.c
+++ b/src/mainboard/google/volteer/romstage.c
@@ -22,4 +22,9 @@
    bool half_populated = gpio_get(GPIO_MEM_CH_SEL);

memcfg_init(mem_cfg, board_cfg, &spd_info, half_populated);
+	memcfg_variant_init(mupd);
+}
+
+void __weak memcfg_variant_init(FSPM_UPD *mupd)
+{
 }
diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h
index 685440c..ba4bf7f 100644
--- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h
+++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h
@@ -21,6 +21,7 @@

const struct mb_cfg *variant_memory_params(void);
 int variant_memory_sku(void);
+void memcfg_variant_init(FSPM_UPD *mupd);

/* Modify devictree settings during ramstage. */
 void variant_devtree_update(void);
diff --git a/src/mainboard/google/volteer/variants/lindar/memory.c b/src/mainboard/google/volteer/variants/lindar/memory.c
index f9350d1..6f61c1c 100644
--- a/src/mainboard/google/volteer/variants/lindar/memory.c
+++ b/src/mainboard/google/volteer/variants/lindar/memory.c
@@ -1,6 +1,7 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

#include <baseboard/variants.h>
+#include <boardid.h>

static const struct mb_cfg board_memcfg = {
    .type = MEM_TYPE_LP4X,
@@ -59,3 +60,11 @@
 {
    return &board_memcfg;
 }
+
+void memcfg_variant_init(FSPM_UPD *mupd)
+{
+	FSP_M_CONFIG *mem_cfg = &mupd->FspmConfig;
+
+	if (board_id() == 1)
+		mem_cfg->SaGv = 0x00;
+}