13 Oct
2020
13 Oct
'20
8:39 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33640 )
Change subject: superio/nuvoton/nct6791d: Add symbol to select COM port ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33640/1/src/superio/nuvoton/common/... File src/superio/nuvoton/common/early_serial.c:
https://review.coreboot.org/c/coreboot/+/33640/1/src/superio/nuvoton/common/... PS1, Line 74: pnp_write_config(dev, 0x2a, 0x00);
yeah, it probably shouldn't matter too much here. […]
Oh, past me, how mistaken you were...
--
To view, visit https://review.coreboot.org/c/coreboot/+/33640
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62dc18810026f9b1550da19950f66af605600ec8
Gerrit-Change-Number: 33640
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Maxim Polyakov m.poliakov@yahoo.com
Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 13 Oct 2020 17:39:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment