Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35484 )
Change subject: util/smc: Add and use new tool smcbiosinfo ......................................................................
Patch Set 7:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35484/5/util/smc/smcbiosinfo/smcbio... File util/smc/smcbiosinfo/smcbiosinfo.c:
https://review.coreboot.org/c/coreboot/+/35484/5/util/smc/smcbiosinfo/smcbio... PS5, Line 71: printf("-b | --boardid <id> The board ID\n");
If the tool is compiled for a single version anyway, would it make sense […]
Done
https://review.coreboot.org/c/coreboot/+/35484/5/util/smc/smcbiosinfo/smcbio... PS5, Line 102: case 'h':
'?': for invalid arguments?
Done
https://review.coreboot.org/c/coreboot/+/35484/5/util/smc/smcbiosinfo/smcbio... PS5, Line 103: usage();
set `ret`?
Done
https://review.coreboot.org/c/coreboot/+/35484/5/util/smc/smcbiosinfo/smcbio... PS5, Line 196: out:
most paths leading here set `ret = 1`, so it would save some lines to […]
Done
https://review.coreboot.org/c/coreboot/+/35484/5/util/smc/smcbiosinfo/smcbio... PS5, Line 197: if (boardid)
No need for that, free() is supposed to check / support NULL.
Done