[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: add support to read spd data from SMBUS

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39401 )

Change subject: soc/intel/tigerlake: add support to read spd data from SMBUS
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39401/5/src/soc/intel/tigerlake/mem... 
File src/soc/intel/tigerlake/meminit_jsl.c:

https://review.coreboot.org/c/coreboot/+/39401/5/src/soc/intel/tigerlake/mem... 
PS5, Line 118: meminit_channels
> Yes, valid point, you would miss Rcomp, DqDqs […]

or call
meminit_dq_dqs_map(mem_cfg, board_cfg, half_populated); from READ_SMBUS if case ? in that way, do are not filling those spdptr without any purpose? calling layer would be reduced ?

if (spd_info->read_type == READ_SMBUS) {
    for (int i = 0; i < NUM_DIMM_SLOT; i++)
    	mem_cfg->SpdAddressTable[i] =
    			spd_info->spd_spec.spd_smbus_address[i];
        meminit_dq_dqs_map(mem_cfg, board_cfg, half_populated);
} else {
    size_t spd_data_len = 0;
    uintptr_t spd_data_ptr = 0;
    memset(&mem_cfg->SpdAddressTable, 0, sizeof(mem_cfg->SpdAddressTable));
    get_spd_data(spd_info, &spd_data_ptr, &spd_data_len);
    print_spd_info((unsigned char *)spd_data_ptr);

mem_cfg->MemorySpdDataLen = spd_data_len;
    meminit_channels(mem_cfg, board_cfg, spd_data_ptr, half_populated);
}