Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/38264 )
Change subject: gma bxt panel: Correct power-cycle delay programming ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/libgfxinit/+/38264/1/common/hw-gfx-gma-panel.a... File common/hw-gfx-gma-panel.adb:
https://review.coreboot.org/c/libgfxinit/+/38264/1/common/hw-gfx-gma-panel.a... PS1, Line 81: function BXT_PP_CONTROL_PWR_CYC_DELAY (US : Natural) return Word32 is
Wouldn't this function look better outside of the register definitions?
To me, Ada will probably never look better. I wanted it here because it's part of the register description.
However, I realize now that we could also write this as expression function:
function BXT_PP_CONTROL_PWR_CYC_DELAY (US : Natural) return Word32 is (Shift_Left (Div_Round_Up32 (US, 100_000) + 1));