Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51374
to look at the new patch set (#2).
Change subject: soc/intel: Calculate SF Mask#1 based on CAR_SF_MASKS_HAS_DOUBLE_TAGS_THAN_DATA_WAYS ......................................................................
soc/intel: Calculate SF Mask#1 based on CAR_SF_MASKS_HAS_DOUBLE_TAGS_THAN_DATA_WAYS
The assumption of SF Mask#1 calculation IA32_CR_SF_QOS_MASK_1 = (1 << 2*number of ways of LLC) - 2^Number of data ways -1 is not always correct.
It depends on parts where tag ways are double than data ways (one way for tracking data and one for SF). If any part has reduced tag ways but not the data ways, this programming of MSR 0x1891 will run into error and eventually part won't boot.
Right now this new Kconfig is only selected on TGL.
TEST=Assume a case where LLC ways for code is 12 and data ways is 1
On TGL: 1. 0xC91 : 0xFFE 2. 0xC92 : 0x01 3. 0x1891: 0xFFFFFF
On ADL: 1. 0xC91 : 0xFFE 2. 0xC92 : 0x01 3. 0x1891: 0xFFF 4. 0x1892: 0x01 5. 0xc85 : 0x01
Change-Id: Ifd0b7e1a90cad4a4837adf6067fe8301dcd0a941 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/common/block/cpu/Kconfig M src/soc/intel/common/block/cpu/car/cache_as_ram.S M src/soc/intel/tigerlake/Kconfig 3 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/51374/2