build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40286 )
Change subject: drivers/ipmi: Implement "IPMI add SEL" function ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40286/1/src/drivers/ipmi/ipmi_ops.h File src/drivers/ipmi/ipmi_ops.h:
https://review.coreboot.org/c/coreboot/+/40286/1/src/drivers/ipmi/ipmi_ops.h... PS1, Line 53: struct standard_spec_sel_rec{ missing space after struct definition
https://review.coreboot.org/c/coreboot/+/40286/1/src/drivers/ipmi/ipmi_ops.h... PS1, Line 63: struct oem_ts_spec_sel_rec{ missing space after struct definition
https://review.coreboot.org/c/coreboot/+/40286/1/src/drivers/ipmi/ipmi_ops.h... PS1, Line 69: struct oem_nots_spec_sel_rec{ missing space after struct definition
https://review.coreboot.org/c/coreboot/+/40286/1/src/drivers/ipmi/ipmi_ops.c File src/drivers/ipmi/ipmi_ops.c:
https://review.coreboot.org/c/coreboot/+/40286/1/src/drivers/ipmi/ipmi_ops.c... PS1, Line 135: if (sel->record_type == 0x2) { braces {} are not necessary for single statement blocks