Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41757 )
Change subject: drivers/vpd: Fix VPD speed regressions on non-x86 devices
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41757/3/src/drivers/vpd/vpd.c
File src/drivers/vpd/vpd.c:
https://review.coreboot.org/c/coreboot/+/41757/3/src/drivers/vpd/vpd.c@123
PS3, Line 123: done = true;
If CBMEM is not available, the rdevs are initialized from memory mapped flash. Once CBMEM is available, the rdevs should then be initalized from CBMEM. The current logic checks "done" and return, thus there is no chance to run init_vpd_rdevs_from_cbmem() to check if CBMEM availability changes since last call.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41757
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55a103180b290c1563e35a25496188b6a82e49ff
Gerrit-Change-Number: 41757
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 27 May 2020 18:52:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment