Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38036 )
Change subject: [UNTESTED] nb/intel/sandybridge: Add a bunch of MCHBAR defines
......................................................................
Patch Set 4:
after merging 38027 this needs a rebase.
did you check if a timeless build results in the same output binary? if the build results in the same binary, i'd count the patch as tested and will do a review
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38036
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e5fe56eaa90842dbbdd1bfbbcb7709237b4c486
Gerrit-Change-Number: 38036
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 01 Jan 2020 16:15:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment