30 Jul
2019
30 Jul
'19
4:27 a.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34140 )
Change subject: lib/bootmem: Prepare for OpenSBI ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34140/2/src/include/bootmem.h File src/include/bootmem.h:
https://review.coreboot.org/c/coreboot/+/34140/2/src/include/bootmem.h@40 PS2, Line 40: BM_MEM_BL31, /* Arm64 BL31 exectuable */ nit: why not insert here so we don't have to churn the cutoff line for every new type?
--
To view, visit https://review.coreboot.org/c/coreboot/+/34140
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ceafd5a295f4284e99e12f7ea2aa4c6d1dbb188
Gerrit-Change-Number: 34140
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: Philipp Hug philipp@hug.cx
Gerrit-Reviewer: Xiang Wang merle@hardenedlinux.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jul 2019 02:27:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment