[coreboot-gerrit] Change in coreboot[master]: soc/intel/broadwell/pch: Replace ACPI device NVS

[Angel Pons (Code Review)]

Attention is currently required from: Nico Huber, Martin Roth, Tim Wawrzynczak, Arthur Heymans, Kyösti Mälkki, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52520 )

Change subject: soc/intel/broadwell/pch: Replace ACPI device NVS
......................................................................

Patch Set 4:

(2 comments)

File src/soc/intel/broadwell/pch/acpi.c:

https://review.coreboot.org/c/coreboot/+/52520/comment/5cf51049_46ba3547 
PS2, Line 18: {
            : 			.type = NAME_STRING,
            : 			.name = SERIALIO_ACPI_PCS,
            : 			.bits = 32,
            : 		};
> what about the macro? […]

Done

https://review.coreboot.org/c/coreboot/+/52520/comment/1e959a47_26e480d6 
PS2, Line 23: const struct opregion opreg = {
            : 			.name         = "SPRT",
            : 			.regionspace  = SYSTEMMEMORY,
            : 			.regionoffset = bar1 + 0x84,
            : 			.regionlen    = spcs.bits / 8,
            : 		};
> Usually yes, because it looks a lot like the ASL it replaces

Done