Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34085 )
Change subject: soc/intel/icelake: Refer to soc/soc_chip.h rather chip.h
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Looks good, just a few minor details.
https://review.coreboot.org/c/coreboot/+/34085/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34085/2//COMMIT_MSG@7
PS2, Line 7: rather
rather *than*
https://review.coreboot.org/c/coreboot/+/34085/2/src/soc/intel/icelake/acpi....
File src/soc/intel/icelake/acpi.c:
https://review.coreboot.org/c/coreboot/+/34085/2/src/soc/intel/icelake/acpi....
PS2, Line 33: #include <soc/soc_chip.h>
Please move these includes so that they are alphabetically ordered
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34085
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e3b5126173e7cec8f2809a38b92c82c9ed5327d
Gerrit-Change-Number: 34085
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 07 Jul 2019 10:28:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment