Shuo Liu has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/84550?usp=email )
Change subject: Documentation/soc/intel/xeon_sp: Update doc to use real FSP headers
......................................................................
Patch Set 3:
(2 comments)
File Documentation/soc/intel/xeon_sp/community_preview_guide.md:
https://review.coreboot.org/c/coreboot/+/84550/comment/b9ec9bff_c9b07b6c?usp... :
PS2, Line 111: to obtain
… them?
Sure, fixed in https://review.coreboot.org/c/coreboot/+/84583.
https://review.coreboot.org/c/coreboot/+/84550/comment/d689fb5c_260e88ad?usp... :
PS2, Line 112: onfigs/builder/config.intel.crb.avc and configs/builder/config.intel.crb.bnc
Mark up the paths?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84550?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a8b01a661a92630d41837a168e17a0fa3c50f04
Gerrit-Change-Number: 84550
Gerrit-PatchSet: 3
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nill Ge
geshijian@bytedance.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Comment-Date: Sun, 29 Sep 2024 07:49:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org