Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43301 )
Change subject: WIP: lib: Add murmur3 algorithm for RAM hash ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43301/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43301/2//COMMIT_MSG@12 PS2, Line 12: I'm not sure we can even include this since it's public domain. We might PD is troublesome because that concept doesn't exist in some places (e.g. Germany), so we should avoid it.
https://review.coreboot.org/c/coreboot/+/43301/2//COMMIT_MSG@14 PS2, Line 14: be fast. Consider xxhash32 (https://github.com/Cyan4973/xxHash) then? it's fast (other benchmarks put it in the same range as murmur3, e.g. http://www.pal-blog.de/entwicklung/perl/hash-function-speed-comparison.html) and BSD-licensed, which is GPL compatible.