Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32376 )
Change subject: superio/fintek/f71808a: Add more optional ramstage registers
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32376/4/src/superio/fintek/f71808a/chip.h
File src/superio/fintek/f71808a/chip.h:
https://review.coreboot.org/#/c/32376/4/src/superio/fintek/f71808a/chip.h@26
PS4, Line 26: _0x27
while these postfixes make the SIO code easier to read, they might make the devicetree settings a bit uglier, since it doesn't really matter there to which register the settings are written to.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32376
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d8008176d2972976b387c558658b8e70b50af8e
Gerrit-Change-Number: 32376
Gerrit-PatchSet: 4
Gerrit-Owner: Max Blau
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Max Blau
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Apr 2019 16:56:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment