Attention is currently required from: Frank Wu, Tim Wawrzynczak, Eric Lai.
Amanda Hwang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63709 )
Change subject: mb/google/brya/var/brya0: Swap TPM and touchscreen I2C bus
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/63709/comment/19057535_7acef9f8
PS1, Line 64: #| I2C2 | |
Please add devices based on the overridetree.cb and the schematic.
Done
https://review.coreboot.org/c/coreboot/+/63709/comment/4e31fa0f_cdb459ad
PS1, Line 70: .speed = I2C_SPEED_FAST,
miss i2c tuning?
add i2c tuning parameter done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63709
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa6235869f34e0038a8ecad33d59654626cf7815
Gerrit-Change-Number: 63709
Gerrit-PatchSet: 2
Gerrit-Owner: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 19 Apr 2022 16:02:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frank Wu
frank_wu@compal.corp-partner.google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment