Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35991 )
Change subject: nb/intel/gm45: Add common code to set up LPC IO decode ranges ......................................................................
Patch Set 4: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/35991/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35991/4//COMMIT_MSG@7 PS4, Line 7: nb/intel/gm45 It's more `sb/intel/i82801ix`?
https://review.coreboot.org/c/coreboot/+/35991/4/src/southbridge/intel/i8280... File src/southbridge/intel/i82801ix/early_init.c:
https://review.coreboot.org/c/coreboot/+/35991/4/src/southbridge/intel/i8280... PS4, Line 84: if (!dev) : return; : if (dev->chip_info) : config = dev->chip_info; : if (!config) : return; : Nit, this can easily be deflated and be written such that one doesn't have to check initialization of `config`...
if (!dev || !dev->chip_info) return; config = dev->chip_info;