Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37285 )
Change subject: mb/lenovo/t420s/devicetree: Use subsystemid inheritance ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37285/1/src/mainboard/lenovo/t420s/... File src/mainboard/lenovo/t420s/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37285/1/src/mainboard/lenovo/t420s/... PS1, Line 2: # IGD Displays This change is out of the scope of this commit
https://review.coreboot.org/c/coreboot/+/37285/1/src/mainboard/lenovo/t420s/... PS1, Line 73: # device specific SPI configuration This one as well
https://review.coreboot.org/c/coreboot/+/37285/1/src/mainboard/lenovo/t420s/... PS1, Line 84: device pci 1a.0 on end # USB Enhanced Host Controller #2 Nit: add a space after each `on` so that all the instances of `end` are aligned