[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8195: Add timer support

[Hung-Te Lin (Code Review)]

Attention is currently required from: Martin Roth, Rex-BC Chen, Yidi Lin, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52541 )

Change subject: soc/mediatek/mt8195: Add timer support
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1:
> gpt6_clk is no longer used on mt8195 timer. […]

I see. There are a few different ways - for example defining a platform-specific function, or use a #define to override the reg to set. For example

// common/timer.h
 enum {
  GPT6_CLK_CLK6_SYS = 0,
  GPT6_CLK_CLKDIV_DIV1 = 0,
 };

// timer_v1.h
 #define GPT6_CLOCK_REG(x) x->gpt6_clk
 DEFINE_BIT(GPT6_CLK_CLK6, 4)
 DEFINE_BITFIELD(GPT6_CLK_CLKDIV, 3, 0)

// timer_v2.h
 #define GPT6_CLOCK_REG(x) x->gpt6_con
 DEFINE_BITFIELD(GPT6_CLK_CLK6, 3, 2)
 DEFINE_BITFIELD(GPT6_CLK_CLKDIV, 13, 0)

Then we can do

SET32_BITFIELDS(&GPT6_CLOCK_REG(mtk_gpt),
                 GPT6_CLK_SRC, GPT6_CLK_CLK6_SYS,
                 GPT6_CLK_DIV, GPT6_CLK_CLKDIV_DIV1);