Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42986 )
Change subject: b/google/vilboz: update GPIOs since Vilboz hardware design follow schematic V3.2 so gpio.c is unnecessary.
......................................................................
Patch Set 9: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/42986/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42986/8//COMMIT_MSG@7
PS8, Line 7: b
mb
https://review.coreboot.org/c/coreboot/+/42986/8//COMMIT_MSG@7
PS8, Line 7: update GPIOs since Vilboz hardware design
: follow schematic V3.2 so gpio.c is unnecessary.
Drop gpio.c from variants/vilboz and this explanation can be moved down to the body of the commit message.
https://review.coreboot.org/c/coreboot/+/42986/8//COMMIT_MSG@10
PS8, Line 10: Delcare
Declare?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42986
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I575f8b233b56185f3281ad7127bc274bda5ea801
Gerrit-Change-Number: 42986
Gerrit-PatchSet: 9
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 07 Jul 2020 04:30:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment