Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30973 )
Change subject: src/mainboard/sony: Add Sony VPCEH2K1E ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/#/c/30973/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30973/4//COMMIT_MSG@12 PS4, Line 12: EC firmware is shared with the main flash chip, it is a chunk of 128KiB
you probably want a custom fmap file to deal with that properly or at least set a cbfssize in Kconfi […]
Alright, I'll need to check how to work with fmaps. Regarding cbfssize, the BIOS region is 2MiB, but these 128 KiB are taken by the EC firmware
https://review.coreboot.org/#/c/30973/4//COMMIT_MSG@14 PS4, Line 14: brightness keys do NOT : work though!
You can get it merged without that, but look for _Qxx methods in the vendor DSDT that implements it.
Right now not even the EC data/cmd ports are visible in /proc/ioports... The backlight itself works btw.
https://review.coreboot.org/#/c/30973/4/src/mainboard/sony/vpceh2k1e/romstag... File src/mainboard/sony/vpceh2k1e/romstage.c:
https://review.coreboot.org/#/c/30973/4/src/mainboard/sony/vpceh2k1e/romstag... PS4, Line 38: 0x82
LPC_EN
Right... Remind myself to fix these in autopork
https://review.coreboot.org/#/c/30973/4/src/mainboard/sony/vpceh2k1e/romstag... PS4, Line 40: pci_write_config32(PCI_DEV(0, 0x1f, 0), 0x88, 0x000c1641);
use LPC_GENx_DEC
Should LPC_GENx_DEC be set here, in devicetree or both?