[coreboot-gerrit] [S] Change in coreboot[master]: {commonlib/drivers}: Have option to store MRC version inside CBMEM

[Arthur Heymans (Code Review)]

Attention is currently required from: Andrey Petrov, Kapil Porwal, Ronak Kanabar, Subrata Banik.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75921?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: {commonlib/drivers}: Have option to store MRC version inside CBMEM
......................................................................

Patch Set 3:

(2 comments)

File src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h:

https://review.coreboot.org/c/coreboot/+/75921/comment/813a545a_a48892a2 :
PS3, Line 116: CBMEM_ID_MRC_VERSION
Why is a new TAG needed?

File src/drivers/intel/fsp2_0/memory_init.c:

https://review.coreboot.org/c/coreboot/+/75921/comment/4de5cbc4_2074b5a4 :
PS3, Line 75: if (CONFIG(MRC_CACHE_USING_MRC_VERSION))
            : 			do_cbmem_version_entry(CBMEM_ID_MRC_VERSION, version);
            : 		else
            : 			do_cbmem_version_entry(CBMEM_ID_FSPM_VERSION, version);
Given that the creation of MRC and FSPM version cbmem is mutually exclusive. Does it even make sense to have a different ID? Can't you rename the existing one to CBMEM_ID_FSPM_OR_MRC_VERSION?