Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37551 )
Change subject: New PCI ID for FCH SATA Controller (AHCI Mode) for AMD driver. ......................................................................
Patch Set 1:
(2 comments)
I would recommend squashing with CB:37546
https://review.coreboot.org/c/coreboot/+/37551/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37551/1//COMMIT_MSG@9 PS1, Line 9: The 1022:7904 FCH This doesn't seem to match what your change is doing.
https://review.coreboot.org/c/coreboot/+/37551/1/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/37551/1/src/include/device/pci_ids.... PS1, Line 451: #define PCI_DEVICE_ID_AMD_CZ_SATA_AHCI_MS 0x7901
Why MS?
"Why MS?" That's how AMD referred to the different IDs in the newer documentation. At this point, I can't recall the exact reasoning. Looking at a Hudson3 RRG for clues, 7801 was called "for ACHI controller" and 7804 was "for AMD AHCI driver". I infer that uses the standard Windows AHCI driver and 7804 requires and AMD driver to be loaded. There may potentially be additional information in AMD's SW stack on devhub.