[coreboot-gerrit] Change in coreboot[master]: lib/edid_fill_fb: Support multiple framebuffers

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39002 )

Change subject: lib/edid_fill_fb: Support multiple framebuffers
......................................................................

Patch Set 14:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39002/14/src/lib/edid_fill_fb.c 
File src/lib/edid_fill_fb.c:

https://review.coreboot.org/c/coreboot/+/39002/14/src/lib/edid_fill_fb.c@78 
PS14, Line 78: 		bits_per_pixel = bpp_mask;
I'm not confident about this one. Why not return NULL? If the fields
are inconsistent how should we know which is correct?

Also, the actual limit is MAX(*_pos + *_size), iow. the end of the
last color component. That might differ because we don't check for
gaps between the components. Should we?

Last but not least, we don't check for the new `bits_per_pixel` if
`x_resolution * bits_per_pixel / 8 <= bytes_per_line` is (still) true.