Attention is currently required from: Lance Zhao, Maxim Polyakov, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49315 )
Change subject: intel/xeon_sp: Use busno register definitions
......................................................................
Patch Set 4: -Code-Review
(1 comment)
File src/soc/intel/xeon_sp/util.c:
https://review.coreboot.org/c/coreboot/+/49315/comment/61380996_d62370b3
PS4, Line 16: &&
Eep! This must not be a logical AND!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49315
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0998053c9f8c690606b91c1b8c0f1d14caf0658
Gerrit-Change-Number: 49315
Gerrit-PatchSet: 4
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 15 Jan 2021 10:21:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment