[coreboot-gerrit] [M] Change in coreboot[main]: soc/mediatek/mt8196: Initialize MCUPM

[Yidi Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu, agogo.

Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85888?usp=email )

Change subject: soc/mediatek/mt8196: Initialize MCUPM
......................................................................

Patch Set 3:

(8 comments)

File src/soc/mediatek/mt8196/include/soc/addressmap.h:

https://review.coreboot.org/c/coreboot/+/85888/comment/0963a059_79713c19?usp... :
PS3, Line 44: APIFRBUS_AO_BASE
remove

File src/soc/mediatek/mt8196/include/soc/mcupm_plat.h:

https://review.coreboot.org/c/coreboot/+/85888/comment/fc72990a_2c16862d?usp... :
PS3, Line 27: APIFRBUS_AO_BASE
IFRBUS_AO_REG_BUS_BASE

https://review.coreboot.org/c/coreboot/+/85888/comment/e9b895d1_86a07851?usp... :
PS3, Line 30: APIFRBUS_AO_BASE
IFRBUS_AO_REG_BUS_BASE

https://review.coreboot.org/c/coreboot/+/85888/comment/ccfb518d_0231aaf0?usp... :
PS3, Line 83: #define SRAM_SLOT_NUM				0x00000014 /* 0x14 = 20 slots = 20*4Bytes = 80 Bytes */
```
/* 0x14 = 20 slots = 20 * 4 Bytes = 80 Bytes */
#define SRAM_SLOT_NUM				0x00000014
```

File src/soc/mediatek/mt8196/mcupm.c:

https://review.coreboot.org/c/coreboot/+/85888/comment/42385aff_72712c58?usp... :
PS3, Line 59: 1
true

https://review.coreboot.org/c/coreboot/+/85888/comment/798dfbbd_94fa2134?usp... :
PS3, Line 59: {
not needed

https://review.coreboot.org/c/coreboot/+/85888/comment/de7431c5_a9c55901?usp... :
PS3, Line 64: 0
false

https://review.coreboot.org/c/coreboot/+/85888/comment/f431ac4f_fe066706?usp... :
PS3, Line 64:  {
not needed