Attention is currently required from: Raul Rangel.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42691 )
Change subject: soc/amd/common: Refactor single GPIO programming
......................................................................
Patch Set 14:
(2 comments)
File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42691/comment/56b2a59f_44a2e333
PS5, Line 214: GPIO_SPECIAL_FLAG
That's the original uncommented code.
Ack
File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42691/comment/3b60e7ed_ad427f4d
PS14, Line 184: g
Can we name it gpio? I only like single character variables names for loop variables.
There's a bunch of abandoned stuff and Felix noted he might want some of that restored. I am not going to go thru the manual rebase trouble to change this. Feel free to do it afterwards.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42691
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7aa6bd6996fd14dde4b1abcccbd2ae6ef933c87b
Gerrit-Change-Number: 42691
Gerrit-PatchSet: 14
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Tue, 02 Feb 2021 19:45:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment