Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/71853 )
Change subject: mb/google/skyrim/var/winterhold: Update I2C bus0 settings ......................................................................
mb/google/skyrim/var/winterhold: Update I2C bus0 settings
Update settings for touchpad I2C frequency and data hold time. I2C frequency and data hold time need to meet touchpad spec. - I2C frequency: 380kHz - 400kHz - Data hold time: 0.3us - 0.9us
BUG=b:262320419 TEST=On winterhold, touchpad i2c measurement from vendor, Frequencies: 395 kHz, Data hold time: 0.66 us
Change-Id: I40fa6f9e88656d4ec02a4120f75a2a9413b5abaa Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/71853 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com --- M src/mainboard/google/skyrim/variants/winterhold/overridetree.cb 1 file changed, 32 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved
diff --git a/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb b/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb index 71888c4..f0dfecc9 100644 --- a/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb +++ b/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb @@ -98,6 +98,16 @@ register "stt_c_apu_F" = "0xE866" register "stt_skin_temp_apu_F" = "0x3200"
+ register "i2c[0]" = "{ + .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_hcnt = 107, + .scl_lcnt = 230, + .sda_hold = 100 + } + }" + device domain 0 on
register "dxio_tx_vboost_enable" = "1"