Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40351 )
Change subject: mb/dell/optiplex_9010: Add Dell OptiPlex 9010 SFF support
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40351/5/src/mainboard/dell/optiplex...
File src/mainboard/dell/optiplex_9010/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40351/5/src/mainboard/dell/optiplex...
PS5, Line 19: sch5545_ecfw.bin
I don't think it's allowed to put blobs in the coreboot repo? Maybe add them to 3rdparty/blobs/mainb […]
The exception is the VBT, which format is quite known. I will move it to blobs then.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40351
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88d65cae30d08ca727d86d930707c2be25a527cf
Gerrit-Change-Number: 40351
Gerrit-PatchSet: 5
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 16 Apr 2020 08:57:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment