build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31059 )
Change subject: src/mb/sifive/hifive-unleashed: initialize Gigabit Ethernet Controller ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/31059/1/src/mainboard/sifive/hifive-unleashe... File src/mainboard/sifive/hifive-unleashed/romstage.c:
https://review.coreboot.org/#/c/31059/1/src/mainboard/sifive/hifive-unleashe... PS1, Line 59: while(*(volatile long*)&nsec > 0) space required before the open parenthesis '('
https://review.coreboot.org/#/c/31059/1/src/mainboard/sifive/hifive-unleashe... PS1, Line 63: #define GPIO_REG(n) (*(uint32_t*)(FU540_GPIO + (n))) "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/31059/1/src/soc/sifive/fu540/clock.c File src/soc/sifive/fu540/clock.c:
https://review.coreboot.org/#/c/31059/1/src/soc/sifive/fu540/clock.c@186 PS1, Line 186: write32(&prci->gemgxlpllcfg1,cfg1); space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/31059/1/src/soc/sifive/fu540/clock.c@191 PS1, Line 191: write32(&prci->gemgxlpllcfg1,cfg1); space required after that ',' (ctx:VxV)