Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37730 )
Change subject: util/autoport: correct build errors of produced files
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37730/4/util/autoport/bd82x6x.go
File util/autoport/bd82x6x.go:
https://review.coreboot.org/c/coreboot/+/37730/4/util/autoport/bd82x6x.go@36...
PS4, Line 360:
For the cosmetic changes: Maybe add a comment here to check if it's necessary
(a lot of LPC routing is set up by default now).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37730
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d1a6af6f1d70268f17692bee130c08502082c97
Gerrit-Change-Number: 37730
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 08 Jan 2020 14:24:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment