Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44102 )
Change subject: [WIP]mb/intel/minnowmax: Add mainboard
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44102/3/src/mainboard/intel/minnowm...
File src/mainboard/intel/minnowmax/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/44102/3/src/mainboard/intel/minnowm...
PS3, Line 27:
The SD card won't work unless you add the following (from the rambi devicetree.cb): […]
maybe just set them in SoC code? If they're magic numbers and need to be the same everywhere, we might as well just hardcode them
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44102
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9a1236425c8a0914f92adcad445230ef2692393a
Gerrit-Change-Number: 44102
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Name of user not set #1002789
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 06 Aug 2020 14:40:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Name of user not set #1002789
Gerrit-MessageType: comment