Attention is currently required from: Wonkyu Kim, John Zhao, Tim Wawrzynczak, Nick Vaccaro, Angel Pons, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60989 )
Change subject: soc/intel: Abstract the common block API for TCSS registers access ......................................................................
Patch Set 13:
(1 comment)
File src/soc/intel/common/block/usb4/usb4.c:
https://review.coreboot.org/c/coreboot/+/60989/comment/5e529c19_9554cce3 PS13, Line 32: tcss_valid_tbt_auth
Literally I meant "config->tcss_ports[i]" for the IOM_TCSS_DEVEN setting.
Sorry John, I made mistake in my comment itself, I have wrongly pasted `CpuPcieRpEnableMask` where I meant `CONFIG(SOC_INTEL_COMMON_BLOCK_TCSS)` check.
My comment above is to suggest if we can update USB4 Kconfig to add a dependency of SOC_INTEL_COMMON_BLOCK_TCSS
https://github.com/coreboot/coreboot/blob/master/src/soc/intel/common/block/...
config SOC_INTEL_COMMON_BLOCK_USB4 bool default n depends on SOC_INTEL_COMMON_BLOCK_TCSS help Minimal PCI Driver for enabling SSDT generation for the DMA component of Intel Thunderbolt/USB4 ports.
otherwise, assume a case when SOC user selects SOC_INTEL_COMMON_BLOCK_USB4 but missed SOC_INTEL_COMMON_BLOCK_TCSS selection then won't we run into compilation issue as per your code https://review.coreboot.org/c/coreboot/+/60989/13/src/soc/intel/common/block... where tcss_valid_tbt_auth() function exist inside tcss.c ?