Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37781 )
Change subject: soc/intel/tigerlake: Update ACPI files ......................................................................
Patch Set 9: Code-Review-1
(5 comments)
The files need to be properly formatted. I stopped reviewing after the second file.
https://review.coreboot.org/c/coreboot/+/37781/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37781/9//COMMIT_MSG@9 PS9, Line 9: tigerlake Tiger Lake
https://review.coreboot.org/c/coreboot/+/37781/9//COMMIT_MSG@10 PS9, Line 10: Please elaborate, what documentation or templates you used.
https://review.coreboot.org/c/coreboot/+/37781/9/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/pch_clock_ctl.asl:
https://review.coreboot.org/c/coreboot/+/37781/9/src/soc/intel/tigerlake/acp... PS9, Line 19: #define B_ICLK_PCR_REQUEST 0x2 Alignment?
https://review.coreboot.org/c/coreboot/+/37781/9/src/soc/intel/tigerlake/acp... PS9, Line 22: Name (SBRG, 0xFD000000) I thought ASL files are formatted differently in coreboot.
https://review.coreboot.org/c/coreboot/+/37781/9/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/37781/9/src/soc/intel/tigerlake/acp... PS9, Line 27: APMS, 8 // APM status Use tabs for alignment?