Attention is currently required from: Eric Lai, Jon Murphy, Karthik Ramasubramanian, Paul Menzel.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75629?usp=email )
Change subject: mb/google/myst: Enable fingerprint on UART
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/myst/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/75629/comment/c620141e_d80db422 :
PS3, Line 71: PAD_GPO(GPIO_40, LOW),
Is there a HW spec requirement for how long the line must stay asserted?
My understanding is that we use `generic.reset_delay_ms` in the device tree to explicitly control how long we keep the reset signal toggled during boot to satisfy any HW requirements. Otherwise, there's no guarantee that the line is asserted long enough in both the cold boot and cold reset cases.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75629?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09819037b80e55edeb56faef9e27fe0753748efc
Gerrit-Change-Number: 75629
Gerrit-PatchSet: 3
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 06 Jun 2023 16:01:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment