Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34343 )
Change subject: configs/config.facebookfbg1710: Add config file
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34343/1/configs/config.facebookfbg1...
File configs/config.facebookfbg1710:
https://review.coreboot.org/c/coreboot/+/34343/1/configs/config.facebookfbg1...
PS1, Line 6: CONFIG_CPU_MICROCODE_CBFS_EXTERNAL_BINS=y
The CPU_UCODE_BINARIES should be available in this config. […]
Done
https://review.coreboot.org/c/coreboot/+/34343/2/configs/config.facebookfbg1...
File configs/config.facebookfbg1710:
PS2:
It's still missing in the build tests on https://qa.coreboot.org/job/coreboot-gerrit/98551/testReport/(root)/board/ because of the naming scheme
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia2cb3bb873b2d5e7e9031e5b249d86605d8e0945
Gerrit-Change-Number: 34343
Gerrit-PatchSet: 2
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 17 Jul 2019 13:09:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks
fhendriks@eltan.com
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment