Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40586 )
Change subject: mb/google/octopus/variants/garg: update Garfour SKU ID
......................................................................
Patch Set 4:
(2 comments)
Renaming done.
Thanks
https://review.coreboot.org/c/coreboot/+/40586/2/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/garg/include/variant/sku.h:
https://review.coreboot.org/c/coreboot/+/40586/2/src/mainboard/google/octopu...
PS2, Line 16: TS_GARFOUR
Can it be renamed as SKU_49_2A2C_TS?
Done
https://review.coreboot.org/c/coreboot/+/40586/2/src/mainboard/google/octopu...
PS2, Line 17: SKU_50_HDMI_GARFOUR
Just SKU_50_HDMI is sufficient. Garfour is probably the SKU name and no need to mention that.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40586
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I656a2bb2404efded6da6697664748b6c8d2ca4e0
Gerrit-Change-Number: 40586
Gerrit-PatchSet: 4
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 Apr 2020 00:41:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment