Attention is currently required from: Xi Chen, Paul Menzel, CK HU, Yu-Ping Wu, Yidi Lin.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44716 )
Change subject: soc/mediatek/mt8192: Do dramc command bus training
......................................................................
Patch Set 56:
(1 comment)
File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/44716/comment/f2eff1fe_00baf7fa
PS42, Line 629: 0xF0000000U
Please define constants for these 2 numbers: 0xF0000000U and 0x0FFFFFFFU.
If anything, I'd write these as `(0xf << 28)` and `~(0xf << 28)` respectively
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44716
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06ee26e3b82811bffa09ab5e3e535b3174c3e3a6
Gerrit-Change-Number: 44716
Gerrit-PatchSet: 56
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: CK HU
ck.hu@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Comment-Date: Thu, 28 Jan 2021 09:38:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment