Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40531 )
Change subject: mb/google/dedede: Remove pad termination for RAM_STRAP_4 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40531/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/romstage.c:
https://review.coreboot.org/c/coreboot/+/40531/2/src/mainboard/google/dedede... PS2, Line 26: if (!google_chromeec_get_board_version(&board_ver)) : half_populated = !gpio_get(GPIO_MEM_CH_SEL);
Sure, but there will be future derivatives too. […]
1. all OEM projects MUST be started with CBI provisioned so board version would be 0 instead of None. As a result, may I know what other deviation we allow future projects to have the deviation here? 2. Dee proto 0 and Doo pre-proto (without CBI provisioned) didn't be built with any SKU in single channel DRAM so default 'half_populated = 0' is good? 3. Of course, if anything wrong in the future device and need workaround for a board version then we can add for sure.