[coreboot-gerrit] Change in coreboot[master]: soc/amd: factor out _SOC_DEV macro into common block

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47515 )

Change subject: soc/amd: factor out _SOC_DEV macro into common block
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/47515/1/src/soc/amd/common/block/in... 
File src/soc/amd/common/block/include/amdblocks/pci_devs.h:

https://review.coreboot.org/c/coreboot/+/47515/1/src/soc/amd/common/block/in... 
PS1, Line 8: !defined
Nit: I know you're just moving the code, but maybe consider doing a positive test and reversing the order?