[coreboot-gerrit] [M] Change in coreboot[master]: cpu/x86/smm: Add PCI BAR store functionality

[Robert Zieba (Code Review)]

Attention is currently required from: Arthur Heymans, Raul Rangel, Nico Huber, Angel Pons, Martin Roth, Karthik Ramasubramanian, Felix Held.

Robert Zieba has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67931 )

Change subject: cpu/x86/smm: Add PCI BAR store functionality
......................................................................

Patch Set 10:

(4 comments)

File src/cpu/x86/smm/pci_bar_store.c:

https://review.coreboot.org/c/coreboot/+/67931/comment/39bbaa4f_6416d2c7 
PS7, Line 20: if (num_devices > num_slots) {
            : 		printk(BIOS_ERR, "Failed to store PCI BARs, number of devices exceeds slots\n");
            : 		return false;
            : 	}
> nit: Would it make sense to do this check inside the for loop so that it can store what bars it can, […]

Moved this into the loop to allow storing at least some BARs if there aren't enough for everything.

https://review.coreboot.org/c/coreboot/+/67931/comment/fb1059b1_99c3f23e 
PS7, Line 26: devices
> You need to make sure the device is a PCI device

Done

File src/cpu/x86/smm/smm_module_loader.c:

https://review.coreboot.org/c/coreboot/+/67931/comment/a5e7d79e_064614d3 
PS7, Line 342: smm_pci_bar_store_init
> if CONFIG(SMM_PCI_BAR_STORE) […]

Done

File src/include/cpu/x86/smm.h:

https://review.coreboot.org/c/coreboot/+/67931/comment/b6b463e0_eb088c35 
PS7, Line 217: #if CONFIG(SMM_PCI_BAR_STORE)
> We shouldn't need to do this.

Done